Skip to content
Snippets Groups Projects

273 pubsec changelog

Closed matograine requested to merge 273_pubsec_changelog into dev
2 unresolved threads
  • change regex for pubsec authfiles to match Duniterpy's format
  • add a changelog check in release.sh

Merge request reports

Pipeline #7831 passed

Pipeline passed for fc495857 on 273_pubsec_changelog

Closed by matograinematograine 4 years ago (Feb 17, 2020 8:16pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
66 * Seed in hexadecimal encoding
67 * PubSec format with public and private key in base58 encoding.
68 """
63 69 file = ctx.obj["AUTH_FILE_PATH"]
64 70 authfile = Path(file)
65 71 if not authfile.is_file():
66 72 message_exit('Error: the file "' + file + '" does not exist')
67 73 filetxt = authfile.open("r").read()
74 # regex for seed (hexadecimal)
68 75 regex_seed = compile("^[0-9a-fA-F]{64}$")
69 regex_gannonce = compile(
70 "^pub: [1-9A-HJ-NP-Za-km-z]{43,44}\nsec: [1-9A-HJ-NP-Za-km-z]{88,90}.*$"
71 )
76 # two RE for PubSec format
77 regex_pubkey = compile("pub: ([1-9A-HJ-NP-Za-km-z]{43,44})", MULTILINE)
78 regex_signkey = compile("sec: ([1-9A-HJ-NP-Za-km-z]{87,90})", MULTILINE)
  • Moul changed milestone to %0.8.0

    changed milestone to %0.8.0

  • Moul
    Moul @moul started a thread on the diff
  • 21 21 fi
    22 22 }
    23 23
    24 check_changelog() {
    25 if [[ ! $(cat CHANGELOG.md | grep "v$VERSION") ]]; then
  • Notes for the future. Can be done, but I can live with that.

    • Can you first create a ticket to check what have to be done, and also to check the priority of a task
    • Then split this MR. One MR per ticket, would ease the review, will go faster. One stuff can block the other. It also makes a cleaner history for the changelog when linking an issue, MR.
    • You can link the new tickets into the commits.
  • closed

  • Moul mentioned in issue #279

    mentioned in issue #279

  • Please register or sign in to reply
    Loading