Co-authored-by: Hugo Trentesaux <hugo.trentesaux@lilo.org>

Co-authored-by: Hugo Trentesaux <hugo.trentesaux@lilo.org>

Co-authored-by: Hugo Trentesaux <hugo.trentesaux@lilo.org>

   * Put back simple `address` and `name` arguments in main.rs (with conflicts_with statement to prevent their usage at the same time)
   * Declared conflicts between indexer <=> no-indexer, indexer <=> network, url <=> network
   * Kept AddressOrVaultNameGroup args for vault usage since it's the only way to define one required arg within a group cleanly

* Relaxed "update" restrictions in vault_account.rs before_save checks

* Started to investigate being able to make subkey command and trying to use sp_core::crypto::CryptoType instead of custom KeyPair
* Big refactoring to have all in one vault_account db table; using recursion through `parent` property
* Added AccountTreeNode object and related methods to be able to more easily handle whole tree of accounts
* Removed now unused vault_derivation
* Replaced remaining usages of `rpassword` and removed the dependency
* Added `indoc` dependency to support cleaner display of multi-line strings in tests

Small cleanup for data's db connection; adding method connect_db that returns a &DatabaseConnection (or panics with explanation message)

Also changed some methods visibility so only connect_db is visible for usage.

Made an extra check of derivation path to make sure it's not linking to the same SS58 Address as "root" suri when doing `vault import|migrate`

* Cleaned-up code in several places
* Now retrieving secret value in "substrate uri" format from the different prompt_xxx_and_compute_keypair methods

* Simply using "name" for the name given to an SS58 Address in the vault

* Added a test to verify we don't need the nacl::sign::Keypair to handle cesium v1 (we can keep using scrypt to retrieve the seed and then sp_core::ed25519::Pair)
** This means we could remove some code linked to that and possibly the `nacl` dependency.

* Fixed small bug after switching from `dialoguer` to `inquire`: using `prompt_skippable()` only returns `None` if the user presses `Esc` (returned "" when user just pressed enter)
* Now using `prompt()` and checking empty string again.

* Adapted to have more coherent commands descriptions and added `long_about` more detailed description for `import` and `derivation`
* Added the `vault list for` command
* Added display of "format" of <Root> derivations in all `vault list` commands
* Only allowing derivations for format "substrate" and "seed"

* Had to bump up the dependency since version 0.6.2 had a bug for the password confirmation - see https://github.com/mikaelmello/inquire/issues/149
* Removed `dialoguer` dependency
* We may want to replace all `rpassword` usage with `inquire` in the future

* Added "/.idea" exclusion in .gitignore (for when using JetBrains IDEs)
* Added dialoguer dependency for easier user input handling (see in inputs.rs)
* Added sea-orm dependency to allow having DB entity mappings and use a local sqlite file database
* Added rstest test dependency for parameterized tests support
* Added derivation tests for each SecretFormat (including cesium v1 key derivation, using sp_core::ed25519::Pair)
* Made a lot of changes to add vault_account and vault_derivation db tables to persist vault keys & derivations
* Added support for KeyPair::Ed25519 linking to sp_core::ed25519::Pair which can be created from secret seed retrieved from nacl::sign::Keypair (which is created from cesium id + secret)
** This was necessary to allow deriving keys from "cesium v1" keys (to be reviewed - it might be a bad idea to permit that from a security point of view)
* Only kept original (substrate) keyfiles support for migration (use "vault list-files" and "vault migrate")
* Added possibility to give either "-a" Address or "-v" Vault Name as general option
* Added extra commands in Vault
** list-files: (deprecated)List available key files (needs to be migrated with command "vault migrate" in order to use them)
** migrate: (deprecated)Migrate old key files into db (will have to provide password for each key)
** 'list' now has sub-commands 'all' or 'root' to show all keys or only root keys (without derivation path)
** use: "Use specific vault key (changes the config address)", which will have the same behaviour as `gcli <-a <Address>|-v <VaultName>> config save` (left a FIXME in there to review)
** derivation: Add a derivation to an existing (root) vault key
** rename: Give a meaningful vault name to a vault key or derivation
** remove: Remove a vault key (and potential derivations if it's a root key)
* Had to bubble up "await" and "async" in a lot of places
* ...

Nicolas80 authored 3 months ago and Hugo Trentesaux committed 3 months ago

* Fixing precision issue when converting the u64 cents amount into f32.
Now composing the displayed value with integer part and fractional part separately (keeping left padding of 0 for the decimal part for the amount of decimals required)

to speed up the process
The runner is not overloaded with one build

This reverts commit 9460516b.

Does not solve the issue, the links do not work anymore:
They need `?job=$job_name` at the end in which the artifacts have been created
https://git.duniter.org/clients/rust/gcli-v2s/-/releases/0.3.1

matograine authored 5 months ago and Moul committed 5 months ago

* CI : remove GET params at the end of assets URLs

on runtime 802
changed crypto types

closes #35

Millicent Billette authored 6 months ago and Hugo Trentesaux committed 6 months ago

* Update README.md

* Add Install instruction