Skip to content
Snippets Groups Projects
Commit ad20da54 authored by Cédric Moreau's avatar Cédric Moreau
Browse files

Resolve #176 "PromotedToSmith is issued even for Smith" (!232)

* fix(#176): last certification does postpone expiry

* test(#176): reveal that last smith certification does not postpone expiry

* fix(#176): clippy

* fix(#176): ExpiresOn is now correctly updated for Pending smiths

* test(#176): show that ExpiresOn is not correctly updated for Pending smiths

* refac(#176): move SmithCertAdded event closer to its storage updates + add docs

* fix(#176): expiration should be postponed only for Pending smiths

* test(#176): reveal that a ceritification on a online smith is bugged

* fix(#176): review: comment

* fix(#176): avoid emitting SmithMembershipAdded twice

* test(#176): reveal bug
parent d029e10c
No related branches found
No related tags found
1 merge request!232Resolve "PromotedToSmith is issued even for Smith"
Pipeline #35679 waiting for manual action
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment