Skip to content
Snippets Groups Projects

Resolve "PromotedToSmith is issued even for Smith"

Merged Cédric Moreau requested to merge 176-promotedtosmith-is-issued-even-for-smith into master

Closes #176 (closed)

Merge request reports

Merge request pipeline #35614 passed

Merge request pipeline passed for 8a578852

Merged by Cédric MoreauCédric Moreau 1 year ago (Jan 24, 2024 12:00pm UTC)

Loading

Pipeline #35617 passed

Pipeline passed for ad20da54 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Cédric Moreau resolved all threads

    resolved all threads

  • Cédric Moreau added 1 commit
  • requested review from @HugoTrentesaux

  • Hugo Trentesaux
  • Cédric Moreau added 4 commits

    added 4 commits

    Compare with previous version

  • Cédric Moreau added 5 commits

    added 5 commits

    Compare with previous version

  • Cédric Moreau added 1 commit
  • Hugo Trentesaux resolved all threads

    resolved all threads

  • Hugo Trentesaux approved this merge request

    approved this merge request

  • 454 // - otherwise we are (still) a pending smith
    447 455 SmithStatus::Pending
    448 456 };
    449 // expiry postponed
    450 let new_expires_on =
    451 CurrentSession::<T>::get() + T::SmithInactivityMaxDuration::get();
    452 smith_meta.expires_on = Some(new_expires_on);
    453 Self::deposit_event(Event::<T>::SmithCertAdded { receiver, issuer });
    454 if smith_meta.status == SmithStatus::Smith {
    457
    458 if smith_meta.status == SmithStatus::Pending {
    459 // - postpone the expiration: a Pending smith cannot do anything but wait
    460 // this postponement is here to ease the process of becoming a smith
    461 let new_expires_on =
    462 CurrentSession::<T>::get() + T::SmithInactivityMaxDuration::get();
    463 smith_meta.expires_on = Some(new_expires_on);
    • Comment on lines +461 to +463

      With this implementation, the last certification does not postpone expiration. So the third certification and the go_online have to be submitted in the 48 sessions (2 days with the current setting) within the period after the second certification. We might want to set this a bit longer for confort.

    • Good point! Fixed.

    • Please register or sign in to reply
  • Cédric Moreau added 2 commits

    added 2 commits

    Compare with previous version

  • Cédric Moreau mentioned in commit ad20da54

    mentioned in commit ad20da54

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading