refactore remove_member_from_blacklist

pallets/authority-members/src/lib.rs

@@ -365,13 +365,15 @@ pub mod pallet {
             member_id: T::MemberId,
         ) -> DispatchResultWithPostInfo {
             T::RemoveMemberOrigin::ensure_origin(origin)?;
-
-            let _ = BlackList::<T>::get()
-                .binary_search(&member_id)
-                .err()
-                .ok_or(Error::<T>::MemberNotBlackListed);
-            Self::remove_blacklist(member_id);
+            BlackList::<T>::mutate(|members_ids| {
+                if let Ok(index) = members_ids.binary_search(&member_id) {
+                    members_ids.remove(index);
+                    Self::deposit_event(Event::MemberRemovedFromBlackList(member_id));
                     Ok(().into())
+                } else {
+                    Err(Error::<T>::MemberNotBlackListed.into())
+                }
+            })
         }
     }
 
@@ -552,15 +554,6 @@ pub mod pallet {
                 }
             });
         }
-        /// perform removal from blacklist
-        fn remove_blacklist(member_id: T::MemberId) {
-            BlackList::<T>::mutate(|members_ids| {
-                if let Ok(index) = members_ids.binary_search(&member_id) {
-                    members_ids.remove(index);
-                }
-            });
-            Self::deposit_event(Event::MemberRemovedFromBlackList(member_id));
-        }
         /// check that accountid is member
         fn verify_ownership_and_membership(
             who: &T::AccountId,