Skip to content
Snippets Groups Projects
Commit fbce116a authored by Mildred Ki'Lya's avatar Mildred Ki'Lya
Browse files

Remove RevocationPeriod

parent 554fe8d2
No related branches found
No related tags found
1 merge request!94Remove RevocationPeriod rule
...@@ -139,7 +139,6 @@ impl pallet_identity::Config for Test { ...@@ -139,7 +139,6 @@ impl pallet_identity::Config for Test {
parameter_types! { parameter_types! {
pub const MembershipPeriod: u64 = 8; pub const MembershipPeriod: u64 = 8;
pub const PendingMembershipPeriod: u64 = 3; pub const PendingMembershipPeriod: u64 = 3;
pub const RevocationPeriod: u64 = 4;
} }
impl pallet_membership::Config<Instance1> for Test { impl pallet_membership::Config<Instance1> for Test {
...@@ -153,7 +152,6 @@ impl pallet_membership::Config<Instance1> for Test { ...@@ -153,7 +152,6 @@ impl pallet_membership::Config<Instance1> for Test {
type MetaData = (); type MetaData = ();
type OnEvent = DuniterWot; type OnEvent = DuniterWot;
type PendingMembershipPeriod = PendingMembershipPeriod; type PendingMembershipPeriod = PendingMembershipPeriod;
type RevocationPeriod = RevocationPeriod;
} }
// Cert // Cert
...@@ -195,7 +193,6 @@ impl pallet_duniter_wot::Config<Instance2> for Test { ...@@ -195,7 +193,6 @@ impl pallet_duniter_wot::Config<Instance2> for Test {
parameter_types! { parameter_types! {
pub const SmithsMembershipPeriod: u64 = 20; pub const SmithsMembershipPeriod: u64 = 20;
pub const SmithsPendingMembershipPeriod: u64 = 3; pub const SmithsPendingMembershipPeriod: u64 = 3;
pub const SmithsRevocationPeriod: u64 = 4;
} }
impl pallet_membership::Config<Instance2> for Test { impl pallet_membership::Config<Instance2> for Test {
...@@ -209,7 +206,6 @@ impl pallet_membership::Config<Instance2> for Test { ...@@ -209,7 +206,6 @@ impl pallet_membership::Config<Instance2> for Test {
type MetaData = (); type MetaData = ();
type OnEvent = SmithsSubWot; type OnEvent = SmithsSubWot;
type PendingMembershipPeriod = SmithsPendingMembershipPeriod; type PendingMembershipPeriod = SmithsPendingMembershipPeriod;
type RevocationPeriod = SmithsRevocationPeriod;
} }
// SmithsCert // SmithsCert
......
...@@ -81,9 +81,6 @@ pub mod pallet { ...@@ -81,9 +81,6 @@ pub mod pallet {
#[pallet::constant] #[pallet::constant]
/// Maximum period (in number of blocks), where an identity can remain pending subscription. /// Maximum period (in number of blocks), where an identity can remain pending subscription.
type PendingMembershipPeriod: Get<Self::BlockNumber>; type PendingMembershipPeriod: Get<Self::BlockNumber>;
#[pallet::constant]
/// Minimum duration (in number of blocks between a revocation and a new entry request
type RevocationPeriod: Get<Self::BlockNumber>;
} }
// GENESIS STUFF // // GENESIS STUFF //
...@@ -356,13 +353,6 @@ pub mod pallet { ...@@ -356,13 +353,6 @@ pub mod pallet {
} }
pub(super) fn do_revoke_membership(idty_id: T::IdtyId) -> Weight { pub(super) fn do_revoke_membership(idty_id: T::IdtyId) -> Weight {
if Self::remove_membership(&idty_id) { if Self::remove_membership(&idty_id) {
if T::RevocationPeriod::get() > Zero::zero() {
let block_number = frame_system::pallet::Pallet::<T>::block_number();
let pruned_on = block_number + T::RevocationPeriod::get();
RevokedMembership::<T, I>::insert(idty_id, ());
RevokedMembershipsPrunedOn::<T, I>::append(pruned_on, idty_id);
}
Self::deposit_event(Event::MembershipRevoked(idty_id)); Self::deposit_event(Event::MembershipRevoked(idty_id));
T::OnEvent::on_event(&sp_membership::Event::MembershipRevoked(idty_id)); T::OnEvent::on_event(&sp_membership::Event::MembershipRevoked(idty_id));
} }
......
...@@ -80,7 +80,6 @@ impl system::Config for Test { ...@@ -80,7 +80,6 @@ impl system::Config for Test {
parameter_types! { parameter_types! {
pub const MembershipPeriod: BlockNumber = 5; pub const MembershipPeriod: BlockNumber = 5;
pub const PendingMembershipPeriod: BlockNumber = 3; pub const PendingMembershipPeriod: BlockNumber = 3;
pub const RevocationPeriod: BlockNumber = 4;
} }
impl pallet_membership::Config for Test { impl pallet_membership::Config for Test {
...@@ -94,7 +93,6 @@ impl pallet_membership::Config for Test { ...@@ -94,7 +93,6 @@ impl pallet_membership::Config for Test {
type MetaData = (); type MetaData = ();
type OnEvent = (); type OnEvent = ();
type PendingMembershipPeriod = PendingMembershipPeriod; type PendingMembershipPeriod = PendingMembershipPeriod;
type RevocationPeriod = RevocationPeriod;
} }
// Build genesis storage according to the mock runtime. // Build genesis storage according to the mock runtime.
......
...@@ -444,7 +444,7 @@ macro_rules! pallets_config { ...@@ -444,7 +444,7 @@ macro_rules! pallets_config {
} }
impl pallet_membership::Config<frame_support::instances::Instance1> for Runtime { impl pallet_membership::Config<frame_support::instances::Instance1> for Runtime {
type IsIdtyAllowedToClaimMembership = Wot; type IsIdtyAllowedToClaimMembership = Wot;
type IsIdtyAllowedToRenewMembership = Wot; type IsIdtyAllowedToRenewMembership = Wot;
type IsIdtyAllowedToRequestMembership = Wot; type IsIdtyAllowedToRequestMembership = Wot;
type Event = Event; type Event = Event;
...@@ -454,7 +454,6 @@ macro_rules! pallets_config { ...@@ -454,7 +454,6 @@ macro_rules! pallets_config {
type MetaData = (); type MetaData = ();
type OnEvent = OnMembershipEventHandler<Wot, Runtime>; type OnEvent = OnMembershipEventHandler<Wot, Runtime>;
type PendingMembershipPeriod = PendingMembershipPeriod; type PendingMembershipPeriod = PendingMembershipPeriod;
type RevocationPeriod = frame_support::traits::ConstU32<0>;
} }
impl pallet_certification::Config<Instance1> for Runtime { impl pallet_certification::Config<Instance1> for Runtime {
...@@ -481,7 +480,7 @@ macro_rules! pallets_config { ...@@ -481,7 +480,7 @@ macro_rules! pallets_config {
} }
impl pallet_membership::Config<Instance2> for Runtime { impl pallet_membership::Config<Instance2> for Runtime {
type IsIdtyAllowedToClaimMembership = SmithsSubWot; type IsIdtyAllowedToClaimMembership = SmithsSubWot;
type IsIdtyAllowedToRenewMembership = SmithsSubWot; type IsIdtyAllowedToRenewMembership = SmithsSubWot;
type IsIdtyAllowedToRequestMembership = SmithsSubWot; type IsIdtyAllowedToRequestMembership = SmithsSubWot;
type Event = Event; type Event = Event;
...@@ -491,7 +490,6 @@ macro_rules! pallets_config { ...@@ -491,7 +490,6 @@ macro_rules! pallets_config {
type MetaData = SmithsMembershipMetaData<opaque::SessionKeysWrapper>; type MetaData = SmithsMembershipMetaData<opaque::SessionKeysWrapper>;
type OnEvent = OnSmithMembershipEventHandler<SmithsSubWot, Runtime>; type OnEvent = OnSmithMembershipEventHandler<SmithsSubWot, Runtime>;
type PendingMembershipPeriod = SmithPendingMembershipPeriod; type PendingMembershipPeriod = SmithPendingMembershipPeriod;
type RevocationPeriod = frame_support::traits::ConstU32<0>;
} }
impl pallet_certification::Config<Instance2> for Runtime { impl pallet_certification::Config<Instance2> for Runtime {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment