fix finalization when using custom genesis

When using a custom genesis, the argument maybe_force_authority forces Alice keys for authority and no other smith to be added as authority. I'm adding the other smith as offline to allow finalisation to perform.

added C-binary RN-silent labels

requested review from @pokapow

marked this merge request as draft

added 3 commits

• 1e677f20 - refac: move stuff and add comments
• 307ed7ee - fix: session keys instead of authority keys
• bf3376c8 - ref: reorder keys to limit confusion

Compare with previous version

I finally found the exact reason of the bug: the development_chain_spec function was sending encoded AuthorityKeys to genesis_data_to_gdev_genesis_conf function which was expecting SessionKeys and decoding as such. The result was that Ed25519 grandpa keys were given to im_online instead, blocking the finalisation.

The fix is only in commit 307ed7ee but I reordered structs to match keystore session keys.

marked this merge request as ready

added 1 commit

• 267b2e19 - refac: simplify syntax

Compare with previous version

added 1 commit

• e4c7223c - review tuxmain

Compare with previous version

added 1 commit

• 76f71613 - clippy

Compare with previous version

resolved all threads

mentioned in commit 22345178

merged