automatically claim membership

closes #159 (closed)
closes #164 (closed)
closes #165 (closed)

pallets/distance/src/lib.rs

@@ -87,6 +87,8 @@ pub mod pallet {
         type WeightInfo: WeightInfo;
         /// Handler for successful distance evaluation
         type OnValidDistanceStatus: OnValidDistanceStatus<Self>;
+        /// Trait to check that distance evaluation request is allowed
+        type CheckRequestDistanceEvaluation: CheckRequestDistanceEvaluation<Self>;
     }
 
     // STORAGE //
@@ -255,7 +257,7 @@ pub mod pallet {
         }
 
         /// Request target identity to be evaluated
-        /// only possible for unconfirmed identity
+        /// only possible for unvalidated identity
         #[pallet::call_index(4)]
         #[pallet::weight(<T as pallet::Config>::WeightInfo::request_distance_evaluation())]
         pub fn request_distance_evaluation_for(
@@ -398,7 +400,6 @@ pub mod pallet {
             // caller has an identity
             let idty_index = pallet_identity::IdentityIndexOf::<T>::get(who)
                 .ok_or(Error::<T>::CallerHasNoIdentity)?;
-            // TODO "check idty call allowed" managed by wot that checks received cert count
             Self::check_request_distance_evaluation_common(idty_index)?;
             Ok(idty_index)
         }
@@ -411,8 +412,6 @@ pub mod pallet {
             // caller has an identity
             let caller_idty_index = pallet_identity::IdentityIndexOf::<T>::get(who)
                 .ok_or(Error::<T>::CallerHasNoIdentity)?;
-            // TODO some of the following can be moved to a "check idty call allowed" managed by wot
-            // which also checks certification count
             let caller_idty = pallet_identity::Identities::<T>::get(caller_idty_index)
                 .ok_or(Error::<T>::CallerIdentityNotFound)?;
             // caller is member
@@ -446,7 +445,9 @@ pub mod pallet {
                 ValidEvaluationResult::<T>::get(target).is_none(),
                 Error::<T>::ValidDistanceResultAlreadyAvailable
             );
-            Ok(())
+            // external validation
+            // target has received enough certifications
+            T::CheckRequestDistanceEvaluation::check_request_distance_evaluation(target)
         }
 
         /// request distance evaluation in current pool