Skip to content
Snippets Groups Projects

#1426: Allow a wider range of Node.js versions and document dependencies to build

Closed #1426: Allow a wider range of Node.js versions and document dependencies to build
5 unresolved threads
Closed Moul requested to merge 1426_allow_wider_node_vers into dev
5 unresolved threads

  • Doc: Add precision to install gcc-c++ for Fedora

Close #1426 (closed).

Edited by Moul

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
23 23 To develop on Duniter, there is currently the following requirement:
24 24
25 25 - A computer with GNU/Linux or Mac as operating system
26 - Build essential tools
26 - Build essential tools: GCC C++
  • Les «build essential tools ne se limites pas à gcc et c++. Tu peut indiquer entre parenthèses que ça inclus entre autre de quoi compiler du C et du C++ mais là ça laisse croire à tord que se serait que ça

  • Moul changed this line in version 2 of the diff

    changed this line in version 2 of the diff

  • Author Owner

    Done.

  • Please register or sign in to reply
  • 13 13 // You should have received a copy of the GNU Affero General Public License
    14 14 // along with this program. If not, see <https://www.gnu.org/licenses/>.
    15 15
    16 extern crate version_compare;
  • 13 13 // You should have received a copy of the GNU Affero General Public License
    14 14 // along with this program. If not, see <https://www.gnu.org/licenses/>.
    15 15
    16 extern crate version_compare;
    17
    16 18 use anyhow::Result;
    17 19 use std::process::{Command, Output};
    18 20 use structopt::StructOpt;
    21 use version_compare::{Version};
  • Éloïs
    Éloïs @librelois started a thread on the diff
  • 13 13 // You should have received a copy of the GNU Affero General Public License
    14 14 // along with this program. If not, see <https://www.gnu.org/licenses/>.
    15 15
    16 extern crate version_compare;
    17
    16 18 use anyhow::Result;
    17 19 use std::process::{Command, Output};
    18 20 use structopt::StructOpt;
    21 use version_compare::{Version};
    19 22
    20 23 const MIN_RUST_VERSION: &str = "1.51.0";
    21 const NODE_VERSION: &str = "10.22.1";
    24 const MIN_NODE_VERSION: &str = "10.18.0";
    25 const MAX_NODE_VERSION: &str = "11.0.0";
  • 54 58
    55 59 if !args.skip_npm {
    56 60 println!("Check node version …");
    57 if exec_and_get_stdout(Command::new("node").arg("-v"))
    58 .unwrap_or_default()
    59 .trim_end()
    60 != format!("v{}", NODE_VERSION)
    61 let node_vers: String = exec_and_get_stdout(Command::new("node").arg("-v"))
    • Il est inutile d'expliciter le type ici car l'inférence de type ne peut pas se tromper, l'inférence est non-ambigue en rust, si plusieurs types différents sont possibles, tu aura une erreur de compilation ;)

    • Moul changed this line in version 2 of the diff

      changed this line in version 2 of the diff

    • Author Owner

      Merci. Done.

    • Please register or sign in to reply
  • @moul tes nom de commit ne respectent pas les nouvelles conventions git du projet : https://git.duniter.org/nodes/typescript/duniter/-/blob/dev/doc/dev/git-conventions.md#naming-commits

    je les au modifiés pour être plus proche de la norme https://www.conventionalcommits.org/en/v1.0.0/ vers laquelle je compte migrer progressivement :)

    Edited by Éloïs
  • @moul tu à oublié de formatter ton code avec rustfmt, pour installer le pre-commit hook qui t'évitera d'oublier de nouveau, il te suffit de compiler les tests avec la commande cargo test --no-run :)

  • removed T-enhancement label

  • Author Owner

    Code formatted and git commit conventions applied. Thanks for the review and the improvements suggestions.

  • Moul changed the description

    changed the description

  • Moul changed title from [enh] #1426 (closed): Allow a wider range of Node.js versions to #1426 (closed): Allow a wider range of Node.js versions and document dependencies to build

    changed title from [enh] #1426 (closed): Allow a wider range of Node.js versions to #1426 (closed): Allow a wider range of Node.js versions and document dependencies to build

  • closed

  • Author Owner

    I don't know what's wrong with this MR, since it doesn't display any diff since my push forces. Let's try with a new MR: !1393 (closed).

    Edited by Moul
  • Please register or sign in to reply
    Loading