#1426: Allow a wider range of Node.js versions and document dependencies to build
- Introduce https://crates.io/crates/version-compare
- Allow Node.js version between 10.18.0 and 11.0.0
- https://nodejs.org/en/download/releases/
- Doc: Add precision to install
gcc-c++
for Fedora
Close #1426 (closed).
Merge request reports
Activity
changed milestone to %2.0
added T-enhancement label
23 23 To develop on Duniter, there is currently the following requirement: 24 24 25 25 - A computer with GNU/Linux or Mac as operating system 26 - Build essential tools 26 - Build essential tools: GCC C++ 13 13 // You should have received a copy of the GNU Affero General Public License 14 14 // along with this program. If not, see <https://www.gnu.org/licenses/>. 15 15 16 extern crate version_compare; 13 13 // You should have received a copy of the GNU Affero General Public License 14 14 // along with this program. If not, see <https://www.gnu.org/licenses/>. 15 15 16 extern crate version_compare; 17 16 18 use anyhow::Result; 17 19 use std::process::{Command, Output}; 18 20 use structopt::StructOpt; 21 use version_compare::{Version}; 13 13 // You should have received a copy of the GNU Affero General Public License 14 14 // along with this program. If not, see <https://www.gnu.org/licenses/>. 15 15 16 extern crate version_compare; 17 16 18 use anyhow::Result; 17 19 use std::process::{Command, Output}; 18 20 use structopt::StructOpt; 21 use version_compare::{Version}; 19 22 20 23 const MIN_RUST_VERSION: &str = "1.51.0"; 21 const NODE_VERSION: &str = "10.22.1"; 24 const MIN_NODE_VERSION: &str = "10.18.0"; 25 const MAX_NODE_VERSION: &str = "11.0.0"; 54 58 55 59 if !args.skip_npm { 56 60 println!("Check node version …"); 57 if exec_and_get_stdout(Command::new("node").arg("-v")) 58 .unwrap_or_default() 59 .trim_end() 60 != format!("v{}", NODE_VERSION) 61 let node_vers: String = exec_and_get_stdout(Command::new("node").arg("-v")) @moul tes nom de commit ne respectent pas les nouvelles conventions git du projet : https://git.duniter.org/nodes/typescript/duniter/-/blob/dev/doc/dev/git-conventions.md#naming-commits
je les au modifiés pour être plus proche de la norme https://www.conventionalcommits.org/en/v1.0.0/ vers laquelle je compte migrer progressivement :)
Edited by Éloïs@moul tu à oublié de formatter ton code avec
rustfmt
, pour installer le pre-commit hook qui t'évitera d'oublier de nouveau, il te suffit de compiler les tests avec la commandecargo test --no-run
:)removed T-enhancement label
changed title from [enh] #1426 (closed): Allow a wider range of Node.js versions to #1426 (closed): Allow a wider range of Node.js versions and document dependencies to build
I don't know what's wrong with this MR, since it doesn't display any diff since my push forces. Let's try with a new MR: !1393 (closed).
Edited by Moul