Skip to content
Snippets Groups Projects
Commit 13c6b2c5 authored by Cédric Moreau's avatar Cédric Moreau
Browse files

fix(#176): ExpiresOn is now correctly updated for Pending smiths

parent 8242c0af
No related branches found
No related tags found
1 merge request!232Resolve "PromotedToSmith is issued even for Smith"
Pipeline #35605 failed
...@@ -461,7 +461,7 @@ impl<T: Config> Pallet<T> { ...@@ -461,7 +461,7 @@ impl<T: Config> Pallet<T> {
let new_expires_on = let new_expires_on =
CurrentSession::<T>::get() + T::SmithInactivityMaxDuration::get(); CurrentSession::<T>::get() + T::SmithInactivityMaxDuration::get();
smith_meta.expires_on = Some(new_expires_on); smith_meta.expires_on = Some(new_expires_on);
// ExpiresOn::<T>::append(new_expires_on, receiver); ExpiresOn::<T>::append(new_expires_on, receiver);
} }
// - if the status is smith but wasn't, notify that smith gained membership // - if the status is smith but wasn't, notify that smith gained membership
......
...@@ -594,7 +594,6 @@ fn certifying_an_online_smith() { ...@@ -594,7 +594,6 @@ fn certifying_an_online_smith() {
received_certs: vec![1, 2] received_certs: vec![1, 2]
}) })
); );
// TODO: test is failing here because ExpiresOn is not correctly updated
assert_eq!(ExpiresOn::<Runtime>::get(7), Some(vec![5])); assert_eq!(ExpiresOn::<Runtime>::get(7), Some(vec![5]));
Pallet::<Runtime>::on_smith_goes_online(5); Pallet::<Runtime>::on_smith_goes_online(5);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment