Fix #291
During an offense, the validator ID/ account ID is used to identify the faulty validator. It is then converted into an identity using identity_index_of from the identity pallet. This identity is subsequently used for all further checks, such as going online or disconnecting the validator. However, the offense system must be able to resolve any validator ID to an identity when processing past offenses that were reported. Therefore, the key should not be changed during this period, which corresponds to ReportLongevity, the maximum reporting duration.
The new behavior is as follows:
- An online smith cannot change its key.
- An offline smith cannot change its key if it is within the bond period, ensuring it can still be punished for past actions.
- An offline smith can change its key at any moment between the end of the last bond period and the
go_onlinecall. Even if the key is changed betweenset_keyandgo_online, the change will be reflected in the authority members' member data.
Merge request reports
Activity
assigned to @bgallois
added RN-runtime label
changed milestone to %runtime-1000
changed title from Draft: Fix {-https://git.duniter.org/nodes/rust/duniter-v2s/-/issues/-}291 to Draft: Fix #291
added 3 commits
- 5c397510 - reproduce #291 (closed)
- eabdadca - fix bad signature shadowed error
- c5d6c8e5 - fix #291 (closed)
added 3 commits
- 0dcbcae8 - reproduce #291 (closed)
- 20c1a81d - fix bad signature shadowed error
- a07776ad - fix #291 (closed)
added 3 commits
- 2fcc5ac0 - reproduce #291 (closed)
- 75f19a0a - fix bad signature shadowed error
- 2aa8e03a - fix #291 (closed)
added 2 commits
added 11 commits
-
fd5112ff...085c8412 - 3 commits from branch
master - 80352b10 - remove unnecessary ownership
- 95b1f703 - reproduce #291 (closed)
- 33ab8ddc - fix bad signature shadowed error
- 7c55b46e - fix #291 (closed)
- e9ee840a - enforce bound period
- c0fc50b6 - refactore double queries
- cf010375 - regenerate metadata
- 62ff71a7 - add reviews
Toggle commit list-
fd5112ff...085c8412 - 3 commits from branch
- Resolved by Benjamin Gallois
One of the new (ignored) tests is not passing after the rebase. Do not merge before I fix it :)
added 9 commits
-
ae224f73 - 1 commit from branch
master - 4ed38683 - remove unnecessary ownership
- 3d40828c - reproduce #291 (closed)
- 87568a28 - fix bad signature shadowed error
- 0f23b7d0 - fix #291 (closed)
- 093a7258 - enforce bound period
- f1c6e12b - refactore double queries
- a1085864 - regenerate metadata
- ad62c3d0 - add reviews
Toggle commit list-
ae224f73 - 1 commit from branch
mentioned in commit 315f93ae
