Fix #291

During an offense, the validator ID/ account ID is used to identify the faulty validator. It is then converted into an identity using identity_index_of from the identity pallet. This identity is subsequently used for all further checks, such as going online or disconnecting the validator. However, the offense system must be able to resolve any validator ID to an identity when processing past offenses that were reported. Therefore, the key should not be changed during this period, which corresponds to ReportLongevity, the maximum reporting duration.

The new behavior is as follows:

• An online smith cannot change its key.
• An offline smith cannot change its key if it is within the bond period, ensuring it can still be punished for past actions.
• An offline smith can change its key at any moment between the end of the last bond period and the go_online call. Even if the key is changed between set_key and go_online, the change will be reflected in the authority members' member data.

runtime/gdev/tests/integration_tests.rs

@@ -1507,7 +1507,7 @@ fn test_change_owner_key_validator_keys_set() {
         let bob = AccountKeyring::Bob.to_account_id();
         let ferdie = AccountKeyring::Ferdie.to_account_id();
         let payload = (b"icok", genesis_hash, 2u32, bob.clone()).encode();
-        let signature = AccountKeyring::Bob.sign(&payload);
+        let signature = AccountKeyring::Ferdie.sign(&payload);
 
         // Bob is not an online validator, but his identity/owner_key is already associated.
         // He should not be able to change its owner_key.
@@ -1536,7 +1536,7 @@ fn test_change_owner_key_validator_online() {
         let alice = AccountKeyring::Alice.to_account_id();
         let ferdie = AccountKeyring::Ferdie.to_account_id();
         let payload = (b"icok", genesis_hash, 1u32, alice.clone()).encode();
-        let signature = AccountKeyring::Alice.sign(&payload);
+        let signature = AccountKeyring::Ferdie.sign(&payload);
 
         // Alice is an online validator
         assert!(pallet_authority_members::OnlineAuthorities::<Runtime>::get().contains(&1));