* review poka

complete comment

* review poka

remove fixme tests

* update metadata after rebase

* I do not know why these tests did not run locally

* update membership weights

* fix benchmarks also with true runtime

* fix tests

* update runtime

* update benchmarks

* split add and renew cert

remove issuer in add_cert
and more refac
the code compiles

* clean up errors and mini refac

* review(#162): `identity_revokes_on` is more accurate

* fix(#162): also make Genesis identity expire at the time expected by G1

* fix(#162): clippy 3

* fix(#162): clippy 2

* fix(#162): clippy

* fix(#162): autorevocation scheduling for Genesis

* fix(#162): cucumber tests

* fix(#162): replace `active` by actual identity status

* increase node spawn timeout to avoid failure

* add points in docstrings

* review

* add missing constant annotation

and update doc

* detail integration test

* comments

* update metadata

* refac certification checks

* clean up error messages and namings

* automatic membership after distance eval

add more details to idty creation test

cargo check ok

add integration test and fix behavior

fix benchmarks for renaming

cargo check ok

cargo test ok

add certification count check

update benchmarks

update distance setup handler

fix weight info

update metadata and generated doc

fix cucumber

distance pallet unit test stub

update metadata and generate doc after rebase

make membership claim no-op an error

update metadata with new error

wip

add comments

add membership renewal antispam

and clean up pending membership parameters

test it

not compatible with keeping distance result

change renewal antispam

metadata

fix param for other runtimes

fix e2e test

remove membership calls

adjust integration tests accordingly

update metadata

fix cucumber

clean up benchmarks and other tests

wip

Benjamin Gallois authored 1 year ago and Hugo Trentesaux committed 1 year ago

* fix chain spec

* fix automatic weights documentation

* fix weights include

* regenerate weights

* refactor cargo alias with constant-fees feature

* add constant fee model for testing

* regenerate weights

* fix benchmark with non constant fees

* fix weight to fee factor

* prepare length to fee logic

* prepare weight to fee logic

Cédric Moreau authored 1 year ago and Hugo Trentesaux committed 1 year ago

* rebase: update metadata.scale

* review: replace `expect` by `if let Some`

* review: lost membership is to be handled by `OnMembershipEventHandler`

* feat(smith-members): review: docstring

* feat(smith-members): review: auteur

* fix(smith-members): test

* clean(smith-members): dead code

* feat(smith-members): disable certification replay

* refac(smith-members): prefix "on_" for handlers

* fix(smith-members): clippy again

* fix(smith-members): clippy

* feat(smith-members): benchmarks

* fix(smith-members): clippy for benchmarking

* refac(smith-members): u32 / usize

* refac(smith-members): cleaner code for smith invitation

* refac(smith-members): wrong TODO

* refac(smith-members): SmithInactivityMaxDuration

* refac(smith-members): remove comment TODO

* refac(smith-members): authority-members OnBlacklistedMember is no more used

* refac(smith-members): authority-members OnRemovedMember is no more used

* fix(smith-members): remove some TODO

* refac(smith-members): remove Instance1 for WoT

* refac(smith-members): remove IsSubWoT

* test(smith-members): non-applicable tests

* test(smith-members): test_revoke_idty

* test(smith-members): test_smith_member_can_revoke_its_idty

* test(smith-members): change_owner_key

* feat(smith-members): replace smith-wot by smith-members

* feat(smith-members): only online smiths can invite/certify other smiths

* feat(smith-members): only WoT members can be invited

* feat(smith-members): check IsWoTMember

* feat(smith-members): refac error names + fix cert on excluded

* feat(smith-members): events

* feat(smith-members): clippy

* feat(smith-members): refact: constants

* feat(smith-members): max stock of certifications per smith

* feat(smith-members): smith account can be excluded, not deleted

* feat(smith-members): refact: renaming

* feat(smith-members): refact: provide_is_member

* feat(smith-members): refact: check_* and do_* functions

* feat(smith-members): remove CertsByReceiver (all in Smiths)

* feat(smith-members): weird things

* feat(smith-members): blacklisting stub

* feat(smith-members): smith expires_on

* feat(smith-members): remove Counted

* feat(smith-members): accept_invitation

* feat(smith-members): invite_smith + certify

Pascal Engélibert authored 1 year ago and Hugo Trentesaux committed 1 year ago

* resolve metadata conflicts

* feat(distance): move max-depth to runtime constant

Benjamin Gallois authored 1 year ago and Hugo Trentesaux committed 1 year ago

* fix no weight

* add const documentation

* refactor error handling

* refactor doc generation

* refactor using if let chaining

* add generic constructor

* add automatic max block weight from metadata

* remove all unwrap

* update docs

* add extrinsic base weight overhead

* update metadata

* fix readability

* add weights to doc

* fix  weight analyzer

* add max_block_weight

* add to workspace

* rework as a lib

* update all weights

* fix overhead benchmark

* add relative weight

* fix weight evaluation with complexity parameters

* add weights computation from weight files

* add check metadata

* Revert "add automatic metadata generation at commit"

This reverts commit b8f0e439.

* add automatic metadata generation at commit

* add clippy checks for runtime-features

* fix clippy errors runtime-benchmarks

* remove unused BenchmarkSetupHandler trait

* optimize AccountLinker

* fix #124

Benjamin Gallois authored 1 year ago and Hugo Trentesaux committed 1 year ago

* fix syntax

* fix change_owner_key test

* fix #153

* fix #147

* add account reaping test

* delete notes.txt file

* update notes with links to issues

* update comment according to #159

* doc idtystatus in readme

* update weightinfo and benchmarks accordingly

* add benchmark

* remove remove_identity_consumers

* remove force_remove_identity call

* fix todo in test

* update doc

- remove request_membership
- remove validate_identity

* fix tests according to new MembershipRemovalReason

* add membership removal reasons

and clean up membership internal functions

* remove check_remove_identity

* build live tests

(but no current network to check them against)

* clippy 

* add wot tests related to issue #136

* refac certification creation checks

* refac identity creation checks

* test benchmark ok

* more precise error messages

* check benchmarks ok

* cargo cucumber ok

* cargo test workspace ok

* cargo test workspace quasi ok

* cargo check all tests

* cargo check all

* remove IdtyEvent change owner key

* remove removal other reason

* refac revocation and removal reason

* wip

* refac

* refac scheduling (tests ok)

* add *Period

* cargo test identity ok

* remove IdtyEvent::Validated

* cargo test wot ok

* cargo test wot ok

(one fails but fot the good reason)

* cargo test membership ok

* cargo check wot tests

* cargo check identity tests

* cargo check membership tests

* also remove validate trait

* remove validate_identity

* refac identity status to allow more fine-grain control

* remove unused trait

* cargo check ok

* remove indentity confirmation constraints

* remove request from membership primitives

* remove request_membership from lib.rs

Benjamin Gallois authored 1 year ago and Hugo Trentesaux committed 1 year ago

* fix weight for handlers

Benjamin Gallois authored 1 year ago and Hugo Trentesaux committed 1 year ago

* fix clippy errors

* add Invalid case in distance status

* fix events pallet-membership

* fix events pallet-certification

* update docs

* update metadata and docs

* refactor errors pallet-distance

* fix distance error naming pallet duniter-wot

* add pallet membership documentation

* refactor acquisition and renewal pallet-membership

* refactor expiration and revokation pallet-membership

* refactor calls pallet-identity

* add pallet standard guidelines

* refactor events struct pallet-membership

* add events pallet-distance

* refactor documentation pallet-quota

* fix pallet-quota features

* refactor documentation pallet-provide-randomness

* refactor documentation pallet-oneshot-account

* refactor documentation pallet-offences

* refactor documentation pallet-membership

* refactor documentation pallet-identity

* refactor documentation pallet-duniter-wot

* refactor documentation pallet-duniter-account

* refactor documentation pallet-distance

* refactor documentation pallet-certification

* refactor documentation pallet-authority-members

* refactor error naming pallet-provide-randomness

* remove unused errors pallet-membership

* remove unused errors pallet-identity

* refactor events and errors pallet-distance

* refactor events and errors pallet-authority-members

Benjamin Gallois authored 1 year ago and Hugo Trentesaux committed 1 year ago

* refactor functions naming for pallet-membership

* refactor functions naming for pallet-certification

* fix tests with runtime-benchmark feature

* fix compilation with runtime-benchmarks feature

* update documentation

* remove handlers weights for pallet_membership

* remove handlers weights for pallet_identity

* remove handlers weights for pallet_certification

* add best practices for benchmarking

* add hooks benchmark pallet_universal_dividend

* add missing benchmarks pallet_universal_dividend

* update weights

* fix pallet_provide_randomness on_initialize weight

* fix pallet_identity weight::zero

* fix pallet_membership weight::zero

* fix pallet_certification weight::zero

* fix pallet_authority_members weight::zero

* fix pallet_identity weight::zero

* fix pallet_membership weight::zero

Benjamin Gallois authored 1 year ago and Hugo Trentesaux committed 1 year ago

* fix process_refund_queue weight

* add weight limit tests

* benchmark process_refund_queue overhead

* add pallet-quota benchmarks

* clippy

* remove membership metadata

* fix(#129): reveal the bug

(cherry picked from commit b60b9345)

Benjamin Gallois authored 1 year ago and Hugo Trentesaux committed 1 year ago

* fix after merge

* add digest decoding complexity

* fix runtime-benchmarks feature for testing

* use our weights

* add benchmarks for test

* add benchmarks for runtime

* add pallet distance benchmarks

* implement quotas

implement weights "à l'arrache"

benchmarks duniter-account "à l'arrache"

implement benchmark logic (not proper benchmarks)

fix live tests 

and clippy 

replace quotas by quota everywhere

comment unused sections of template

remove quota treasury dependency

give treasury address as argument

typo

review tuxmain

doc readme

rename error DistanceKO to DistanceNotOK

merge new owner key and revocation signature

merge signature error types

rename NewOwnerKeyPayload

fix comment

make eligibility more explicit

implement quotas

implement weights "à l'arrache"

benchmarks duniter-account "à l'arrache"

implement benchmark logic (not proper benchmarks)

fix live tests 

and clippy 

replace quotas by quota everywhere

comment unused sections of template

remove quota treasury dependency

give treasury address as argument

typo

review tuxmain

doc readme

rename error DistanceKO to DistanceNotOK

merge new owner key and revocation signature

merge signature error types

rename NewOwnerKeyPayload

fix comment

make eligibility more explicit

update metadata

fix

fix fee multiplier update

prevent network discovery + connecting other nodes

Benjamin Gallois authored 1 year ago and Hugo Trentesaux committed 1 year ago

* remove comment

* update docs

* fix benchmarks test suite

* refactore SetupBenchmark

* update pallet identity

* remove gdev_benchmark

Benjamin Gallois authored 1 year ago and Hugo Trentesaux committed 1 year ago

* refac(benchmark) refactore BenchmarkSetupHandler

* fix(pallet_membership): fix benchmarks

* fix(pallet_identity): fix benchmarks

Benjamin Gallois authored 1 year ago and Hugo Trentesaux committed 1 year ago

* allow clippy needless_pass_by_ref_mut

* fix clippy

°_°

* fix provider behavior

* fix build errors

* change behavior of going below ED

* fix provider initialization

* add mock epoch change

* add session number test

* add session number test

* WIP fix tests

* fix time-based ud test

* update metadata

* FIX apply all fix from flash branch

* partial fix clippy

other suggestions are not legit

* fix metadata and end2end test

* fix build tests

* fix build and clippy

* remove benchmark of upgrade_accounts

this happens in substrate dependency
I also updated other packages because why not :D
and I removed a useless implementation in mock
but the test do not compile with feature runtime benchmarks anyway

* test_total_issuance_vs_monetary_mass

* proofreading comment

* fix total issuance differently

this actually fixes total issuance at genesis
instead of creating duplicate account data

* fix test scenario

the thing tested here was not the ability to call the function,
but the impossibility of deleting the account

* add comment to explain test

* fix providers and sufficients counts

* fix initial balance

* fix initial TotalIssuance

* fix clippy warnings and optimization

* fix xtask

* update docs

* add DustHandle

* fix pallets config

* fix tests

* fix pallet_balance genesis config

* wip: fix end2end-test

* fix manual and instant sealing

* fix live-tests

* fix offences after rebase

* generate all weights

* add rust toolchain file

* fix benchmarks

Pallet balances benchmarks need https://github.com/duniter/substrate/commit/c36ab4f32454318a47777b24b6533c44121fc10b because pallet duniter-account add another provider.

* fix babe-worker

* fix subxt dependency

* fix ImplicitCallIndex and Weight::from_ref_time deprecation

* fix consensus_babe dependency

* regenerate weights

Regenerate all weights except for pallet-balance failing on one extrinsic

* workaround pallet_duniter_account

Workaround to be able to pass https://github.com/paritytech/substrate/blob/6ef184e33f6ce0f56999ae84b212ea6148c0624d/frame/balances/src/benchmarking.rs#L271 in the benchmark.
ExtraFlags is private and Default is always new_logic not suitable for the benchmark.

* wip fix node errors

* wip fix runtime errors

* fix pallet-duniter-account errors

* fix pallet-balance errors

* fix pallet-identity errors

* fix pallet-duniter-account errors

* upgrade Cargo files

* update docs

Pascal Engélibert authored 1 year ago and Hugo Trentesaux committed 1 year ago

* Fix distance-oracle EvaluationPool type

* Remove instanciation and dep to certification

* Doc comments, make max size params const

* Fix default distance dir

* Rename pool accessors

* doc add READMEs

* fix(distance): Remember account_id who reserved

* Log, comments, crate author

* feat: distance

* integration tests, expiration

* fixes & working end2end tests

* fix(distance): max_depth, compute min_certs_for_referee

* fix(distance): add distance pallet to gtest, g1

* test(distance): WiP end2end test

* feat: distance

* Rename associated type Other to OtherReason

* Fix benchmarks

* feat: Identity removal reason

Benjamin Gallois authored 1 year ago and Hugo Trentesaux committed 1 year ago

* fix cargo files

* fix slashing strategy

* refactore remove_member_from_blacklist

* add missing test

* add license

* refac tests

adds comments
remove some repetitions
reorder tests (offence test are below)
rename tests

* feat(pallet_grandpa) add offences handler

* feat(pallet_authority_members) add offences execution

* feat(pallet_offences) add pallet offences

Benjamin Gallois authored 1 year ago and Hugo Trentesaux committed 1 year ago

* Add extrinsic_weights benchmark

* Fix block_weights benchmark

Hugo Trentesaux authored 1 year ago and Pascal Engélibert committed 1 year ago

* review tuxmain

* fix rebase

* rename force_add_cert to do_add_cert_checked

* remove origin from force_add_cert

* remove duplicate UD handling

* claim membership - validating identity

ensure claim membership does not prevent validating identity

* clippy

* add acquired membership handler

and new integration test scenario

* run benchmarks

* refactor claim_membership

and expire membership instead of revoking
when too few certs

* re-enable claim_membership

* membership expiry no identity removal

membership expiry no more triggers identity removal

* control by test

* at membership expiry : back to pending membership

* reveal identity removal on membership expiry

* refac test

* refac membership renewal

add expiry unscheduling
do not verify expiration block expiring memberships
add and refac tests
add integration test

* wip

Benjamin Gallois authored 1 year ago and Hugo Trentesaux committed 1 year ago

* feat: add pallet session benchmark

* fix(pallet_collective): fix parameters for benchmark

* fix(pallet_treasury): fix parameters for benchmark

* fix(pallet_im_online): fix parameters for benchmark

Fixed the pallet_im_online parameters to be pass benchmarks. MaxKeys needs to be at least 1000 because of https://github.com/paritytech/substrate/blob/e94cb0dafd4f30ff29512c1c00ec513ada7d2b5d/frame/im-online/src/benchmarking.rs#L35

* feat(runtimes): use our benchmarks for substrate pallets

Benjamin Gallois authored 1 year ago and Hugo Trentesaux committed 1 year ago

* fix after rebase

* feat(runtimes): use our benchmarks for pallet authority_members

* feat(pallet_authority_members): add weights info

* feat: add pallet authority_members benchmark

Benjamin Gallois authored 1 year ago and Hugo Trentesaux committed 1 year ago

* fix after rebase

* add comment warning about hardcoded smith metadata

* feat(runtimes): use our benchmarks for pallet membership

* feat(pallet_membership): add weights info

* feat: add pallet membership benchmark

Benjamin Gallois authored 1 year ago and Hugo Trentesaux committed 1 year ago

* feat(runtimes): use our benchmarks for pallet oneshot_account

* feat(pallet_oneshot_account): add weights info

* fix(pallet_oneshot_account): remove unecessary where clause

duplicate functions
renamed smiths -> smith